Messages in this thread | | | From | "Eric W. Biederman" <> | Date | Fri, 30 Sep 2022 11:35:38 -0500 | Subject | Re: [PATCH] binfmt: remove taso from linux_binprm struct |
| |
Kees Cook <keescook@chromium.org> writes:
> On Thu, Sep 29, 2022 at 05:17:28PM -0500, Eric W. Biederman wrote: >> Lukas Bulwahn <lukas.bulwahn@gmail.com> writes: >> >> > With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the >> > use of the special taso flag for alpha architectures in the linux_binprm >> > struct is gone. >> > >> > Remove the definition of taso in the linux_binprm struct. >> > >> > No functional change. >> >> Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com> >> >> Alphas binfmt_loader is the only use I can find of that variable >> so let's kill it as well. > > Ah, sorry, misparsed this -- you mean, alpha's use (now removed) was the > only place it was accessed. Agreed. :)
Yes. I was looking in a tree without my previous change merged.
The code in binfmt_loader (which is removed in the my change) was the only user of that variable I could find.
Eric
| |