Messages in this thread | | | Date | Fri, 30 Sep 2022 22:43:04 +0800 | Subject | Re: [PATCH v1 1/2] clocksource: loongson2_hpet: add hpet driver support | From | WANG Xuerui <> |
| |
Hi,
On 9/30/22 17:35, Yinbo Zhu wrote: > HPET (High Precision Event Timer) defines a new set of timers, which > are used by the operating system to schedule threads, interrupt the > kernel and interrupt the multimedia timer server. The operating > system can assign different timers to different applications. By > configuration, each timer can generate interrupt independently. > > The loongson2 HPET module includes a main count and three comparators > , all of which are 32 bits wide. Among the three comparators, only > one comparator supports periodic interrupt, all three comparators > support non periodic interrupts. > > Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> > --- > MAINTAINERS | 6 + > arch/loongarch/kernel/time.c | 3 + > drivers/clocksource/Kconfig | 9 + > drivers/clocksource/Makefile | 1 + > drivers/clocksource/loongson2_hpet.c | 332 +++++++++++++++++++++++++++ > 5 files changed, 351 insertions(+) > create mode 100644 drivers/clocksource/loongson2_hpet.c
Thanks for the contribution, but as HPET is a fairly common peripheral that have well standardized behavior, why not simply add DT support to the drivers/char/hpet.c and be done with it?
-- WANG "xen0n" Xuerui
Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/
| |