Messages in this thread Patch in this message | | | Date | Fri, 30 Sep 2022 15:18:12 +0200 | Subject | Re: [PATCH v7, 2/3] mailbox: mtk-cmdq: add gce ddr enable support flow | From | Matthias Brugger <> |
| |
On 30/09/2022 11:59, Yongqiang Niu wrote: > add gce ddr enable control flow when gce suspend/resume > > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com> > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index 04eb44d89119..84a60750d0c4 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -94,6 +94,21 @@ struct gce_plat { > u32 gce_num; > }; > > +static void cmdq_sw_ddr_enable(struct cmdq *cmdq, bool enable) > +{ > + if (!cmdq->sw_ddr_en) > + return; > + > + WARN_ON(clk_bulk_enable(cmdq->gce_num, cmdq->clocks)); > + > + if (enable) > + writel(GCE_DDR_EN | GCE_CTRL_BY_SW, cmdq->base + GCE_GCTL_VALUE); > + else > + writel(GCE_CTRL_BY_SW, cmdq->base + GCE_GCTL_VALUE); > + > + clk_bulk_disable(cmdq->gce_num, cmdq->clocks); > +} > + > u8 cmdq_get_shift_pa(struct mbox_chan *chan) > { > struct cmdq *cmdq = container_of(chan->mbox, struct cmdq, mbox); > @@ -319,6 +334,8 @@ static int cmdq_suspend(struct device *dev) > if (task_running) > dev_warn(dev, "exist running task(s) in suspend\n"); > > + cmdq_sw_ddr_enable(cmdq, false);
I'd say if (!cmdq->sw_ddr_en) should be checked before calling cmdq_sw_ddr_enable().
Regards, Matthias
> + > clk_bulk_unprepare(cmdq->gce_num, cmdq->clocks); > > return 0; > @@ -330,6 +347,9 @@ static int cmdq_resume(struct device *dev) > > WARN_ON(clk_bulk_prepare(cmdq->gce_num, cmdq->clocks)); > cmdq->suspended = false; > + > + cmdq_sw_ddr_enable(cmdq, true); > + > return 0; > } > > @@ -337,6 +357,8 @@ static int cmdq_remove(struct platform_device *pdev) > { > struct cmdq *cmdq = platform_get_drvdata(pdev); > > + cmdq_sw_ddr_enable(cmdq, false); > + > clk_bulk_unprepare(cmdq->gce_num, cmdq->clocks); > return 0; > }
| |