Messages in this thread | | | Date | Sat, 1 Oct 2022 00:55:33 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH] x86/sgx: Replace kmap/kunmap_atomic calls |
| |
On Thu, Sep 29, 2022 at 09:06:46AM -0700, Kristen Carlson Accardi wrote: > It is not necessary to disable page faults or preemption when > using kmap calls, so replace kmap_atomic() and kunmap_atomic() > calls with more the more appropriate kmap_local_page() and > kunmap_local() calls. > > Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
Missing "why". I believe you're right but since the existing code is working, you should extend the reasoning just a bit.
BR, Jarkko
| |