Messages in this thread | | | Date | Fri, 30 Sep 2022 23:44:21 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH 3/3] tpm: st33zp24: remove pointless checks on probe |
| |
On Sun, Sep 25, 2022 at 10:39:58PM -0700, Dmitry Torokhov wrote: > Driver core will never call driver's probe method without appropriate > device structure, so testing them for NULL is pointless. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Missing a description what the patch does.
Also instead of "driver's probe method" you could just use "st33zp24_i2c_probe()". It's even shorter.
BR, Jarkko
| |