Messages in this thread Patch in this message | | | From | Namhyung Kim <> | Subject | [PATCH 2/7] perf stat: Don't call perf_stat_evsel_id_init() repeatedly | Date | Fri, 30 Sep 2022 13:21:05 -0700 |
| |
The evsel__reset_stat_priv() is called more than once if user gave -r option for multiple run. But it doesn't need to re-initialize the id.
Reviewed-by: James Clark <james.clark@arm.com> Signed-off-by: Namhyung Kim <namhyung@kernel.org> --- tools/perf/util/stat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c index 6bcd3dc32a71..e1d3152ce664 100644 --- a/tools/perf/util/stat.c +++ b/tools/perf/util/stat.c @@ -135,7 +135,6 @@ static void evsel__reset_stat_priv(struct evsel *evsel) struct perf_stat_evsel *ps = evsel->stats; init_stats(&ps->res_stats); - perf_stat_evsel_id_init(evsel); } static int evsel__alloc_stat_priv(struct evsel *evsel) @@ -143,6 +142,7 @@ static int evsel__alloc_stat_priv(struct evsel *evsel) evsel->stats = zalloc(sizeof(struct perf_stat_evsel)); if (evsel->stats == NULL) return -ENOMEM; + perf_stat_evsel_id_init(evsel); evsel__reset_stat_priv(evsel); return 0; } -- 2.38.0.rc1.362.ged0d419d3c-goog
| |