lkml.org 
[lkml]   [2022]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/8] arm64: dts: qcom: sdm845-tama: Add display nodes
From


On 30.09.2022 22:10, Krzysztof Kozlowski wrote:
> On 30/09/2022 21:10, Konrad Dybcio wrote:
>> Add required nodes to support display on XZ2/XZ2c. XZ3 has a
>> different power rail setup and needs to be handled separately.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>> ---
>> .../qcom/sdm845-sony-xperia-tama-akari.dts | 4 +
>> .../qcom/sdm845-sony-xperia-tama-akatsuki.dts | 44 ++++++++-
>> .../qcom/sdm845-sony-xperia-tama-apollo.dts | 6 ++
>> .../dts/qcom/sdm845-sony-xperia-tama.dtsi | 96 +++++++++++++++++++
>> 4 files changed, 149 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akari.dts b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akari.dts
>> index 34f84f1f1eb4..d97b7f1e7140 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akari.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akari.dts
>> @@ -11,3 +11,7 @@ / {
>> model = "Sony Xperia XZ2";
>> compatible = "sony,akari-row", "qcom,sdm845";
>> };
>> +
>> +&panel {
>> + compatible = "sony,td4353-jdi-tama";
>
> git grep suggests it is not documented. Is it coming via different patchset?
As mentioned in the cover letter, yes.

>
>> +};
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
>> index 2f5e12deaada..2a16305ac5da 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
>> @@ -10,9 +10,51 @@
>> / {
>> model = "Sony Xperia XZ3";
>> compatible = "sony,akatsuki-row", "qcom,sdm845";
>> +
>> + /* Fixed DCDC for the OLED panel */
>> + ts_vddio_supply: ts-vddio-regulator {
>> + compatible = "regulator-fixed";
>> + regulator-name = "ts_vddio";
>> +
>> + regulator-min-microvolt = <1840000>;
>> + regulator-max-microvolt = <1840000>;
>> +
>> + gpio = <&tlmm 133 GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + regulator-boot-on;
>> + };
>> +};
>> +
>> +&ibb {
>> + status = "disabled";
>> +};
>> +
>> +&lab {
>> + status = "disabled";
>> +};
>> +
>> +&panel {
>> + /* Akatsuki uses an OLED panel. */
>> + /delete-property/ backlight;
>> + /delete-property/ vsp-supply;
>> + /delete-property/ vsn-supply;
>> + /delete-property/ treset-gpios;
>> +};
>> +
>> +&pmi8998_wled {
>> + status = "disabled";
>> +};
>> +
>> +&tlmm {
>> + ts_vddio_en: ts-vddio-en {
>
> ts-vddio-en-state
>
> DT schema is coming:
> https://lore.kernel.org/linux-devicetree/20220930200529.331223-1-krzysztof.kozlowski@linaro.org/T/#t
Right, missed this one. Will fix.

Konrad
>
>> + pins = "gpio133";
>> + function = "gpio";
>> + drive-strength = <2>;
>> + bias-disable;
>> + output-high;
>> + };
>
> Best regards,
> Krzysztof
>

\
 
 \ /
  Last update: 2022-09-30 22:13    [W:0.053 / U:1.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site