Messages in this thread | | | From | Clément Péron <> | Date | Sat, 3 Sep 2022 20:41:36 +0200 | Subject | Re: [PATCH v2 4/4] arm64: dts: allwinner: beelink-gs1: Enable GPU OPP |
| |
Hi Samuel,
On Tue, 23 Aug 2022 at 05:07, Samuel Holland <samuel@sholland.org> wrote: > > On 8/21/22 12:30 PM, Clément Péron wrote: > > Enable GPU OPP table for Beelink GS1 > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > --- > > arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts > > index 6249e9e02928..20fc0584d1c6 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts > > @@ -5,6 +5,7 @@ > > > > #include "sun50i-h6.dtsi" > > #include "sun50i-h6-cpu-opp.dtsi" > > +#include "sun50i-h6-gpu-opp.dtsi" > > > > #include <dt-bindings/gpio/gpio.h> > > > > @@ -261,6 +262,7 @@ reg_dcdca: dcdca { > > }; > > > > reg_dcdcc: dcdcc { > > + regulator-always-on; > > Why is this necessary? This file already has:
This is a relica from the first serie at this time the OPP doesn't properly enable the regulator it's now fixed since: https://patchwork.kernel.org/project/linux-pm/patch/81eb2efeeed1556d124065252f32777838a6d850.1589528491.git.viresh.kumar@linaro.org/
I will drop it.
Thanks for the review. Regards, Clement
> > &gpu { > mali-supply = <®_dcdcc>; > status = "okay"; > }; > > So there is a consumer for this regulator. > > Regards, > Samuel > > > regulator-enable-ramp-delay = <32000>; > > regulator-min-microvolt = <810000>; > > regulator-max-microvolt = <1080000>; > > >
| |