lkml.org 
[lkml]   [2022]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/3] iio: temperature: mlx90632 Add runtime powermanagement modes
On Sat, Sep 3, 2022 at 3:06 PM Crt Mori <cmo@melexis.com> wrote:
> On Fri, 2 Sept 2022 at 20:39, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Fri, Sep 2, 2022 at 8:59 PM Crt Mori <cmo@melexis.com> wrote:
> > > On Fri, 2 Sept 2022 at 17:28, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > > > On Fri, Sep 2, 2022 at 4:13 PM <cmo@melexis.com> wrote:

...


> > > > > + if (current_powerstatus == MLX90632_PWR_STATUS_SLEEP_STEP)
> > > > > + return mlx90632_pwr_set_sleep_step(data->regmap);
> > > >
> > > > > + else
> > > >
> > > > Redundant.
> > > >
> > > No, the powermode changes among the type.
> >
> > Yes. 'else' keyword is always redundant in the
> >
> > if (...)
> > return / break / continue / goto
> > else

> > cases.
> >
> In this case current power mode of the sensor is halt, so the else is
> needed to set it to continuous mode, which means I can't just remove
> the else here because this statement restores the power mode before
> this function was entered (and changed powermode for the setup).

What do you mean by all this? Read your code again and see what I'm
talking about...

> > > > > + return mlx90632_pwr_continuous(data->regmap);

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-09-03 16:00    [W:0.051 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site