lkml.org 
[lkml]   [2022]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/3] dma-buf: Remove the signaled bit status check
    From
    Am 27.09.22 um 19:24 schrieb Arvind Yadav:
    > Remove the extra signaled bit status check because
    > it is returning early when the fence is already signaled and
    > __dma_fence_enable_signaling is checking the status of signaled
    > bit again.
    >
    > Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>

    Reviewed-by: Christian König <christian.koenig@amd.com>

    > ---
    > drivers/dma-buf/dma-fence.c | 5 -----
    > 1 file changed, 5 deletions(-)
    >
    > diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
    > index 406b4e26f538..11ef20f70ee0 100644
    > --- a/drivers/dma-buf/dma-fence.c
    > +++ b/drivers/dma-buf/dma-fence.c
    > @@ -648,11 +648,6 @@ int dma_fence_add_callback(struct dma_fence *fence, struct dma_fence_cb *cb,
    > if (WARN_ON(!fence || !func))
    > return -EINVAL;
    >
    > - if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
    > - INIT_LIST_HEAD(&cb->node);
    > - return -ENOENT;
    > - }
    > -
    > spin_lock_irqsave(fence->lock, flags);
    >
    > if (__dma_fence_enable_signaling(fence)) {

    \
     
     \ /
      Last update: 2022-09-29 20:16    [W:3.643 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site