Messages in this thread | | | Date | Thu, 29 Sep 2022 11:51:00 +0530 | Subject | Re: [PATCH 3/4] dt-bindings: net: snps,dwmac: Update reg maxitems | From | Bhupesh Sharma <> |
| |
Hi Rob,
On 9/13/22 2:44 AM, Rob Herring wrote: > On Tue, Sep 13, 2022 at 12:23:42AM +0530, Bhupesh Sharma wrote: >> On 9/8/22 8:11 PM, Krzysztof Kozlowski wrote: >>> On 07/09/2022 22:49, Bhupesh Sharma wrote: >>>> Since the Qualcomm dwmac based ETHQOS ethernet block >>>> supports 64-bit register addresses, update the >>>> reg maxitems inside snps,dwmac YAML bindings. >>> >>> Please wrap commit message according to Linux coding style / submission >>> process: >>> https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 >>> >>>> >>>> Cc: Bjorn Andersson <andersson@kernel.org> >>>> Cc: Rob Herring <robh@kernel.org> >>>> Cc: Vinod Koul <vkoul@kernel.org> >>>> Cc: David Miller <davem@davemloft.net> >>>> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> >>>> --- >>>> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>>> index 2b6023ce3ac1..f89ca308d55f 100644 >>>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>>> @@ -94,7 +94,7 @@ properties: >>>> reg: >>>> minItems: 1 >>>> - maxItems: 2 >>>> + maxItems: 4 >>> >>> Qualcomm ETHQOS schema allows only 2 in reg-names, so this does not make >>> sense for Qualcomm and there are no users of 4 items. >> >> On this platform the two reg spaces are 64-bit, whereas for other >> platforms based on dwmmac, for e.g. stm32 have 32-bit address space. > > The schema for reg is how many addr/size entries regardless of cell > sizes. > >> Without this fix I was getting the following error with 'make dtbs_check': >> >> Documentation/devicetree/bindings/net/qcom,ethqos.example.dtb: >> ethernet@20000: reg: [[0, 131072], [0, 65536], [0, 221184], [0, 256]] is too >> long >> From schema: /home/bhsharma/code/upstream/linux-bckup/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > The default cell sizes for examples is 1 for addr/size. If you want it > to be 2, you have to write your own parent node. But why? It's just an > example. Use 1 cell like the example originally had.
Got your point. Let me revert to the original example in v2.
Thanks, Bhupesh
| |