Messages in this thread Patch in this message | | | From | Baoquan He <> | Subject | [PATCH RESEND 1/4] proc/vmcore: fix potential memory leak in vmcore_init() | Date | Thu, 29 Sep 2022 12:29:33 +0800 |
| |
From: Jianglei Nie <niejianglei2021@163.com>
elfcorehdr_alloc() allocates a memory chunk for elfcorehdr_addr with kzalloc(). If is_vmcore_usable() returns false, elfcorehdr_addr is a predefined value. If parse_crash_elf_headers() gets some error and returns a negetive value, the elfcorehdr_addr should be released with elfcorehdr_free().
Fix it by calling elfcorehdr_free() when parse_crash_elf_headers() fails.
Signed-off-by: Jianglei Nie <niejianglei2021@163.com> Acked-by: Baoquan He <bhe@redhat.com> Signed-off-by: Baoquan He <bhe@redhat.com> --- fs/proc/vmcore.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index f2aa86c421f2..74747571d58e 100644 --- a/fs/proc/vmcore.c +++ b/fs/proc/vmcore.c @@ -1567,6 +1567,7 @@ static int __init vmcore_init(void) return rc; rc = parse_crash_elf_headers(); if (rc) { + elfcorehdr_free(elfcorehdr_addr); pr_warn("Kdump: vmcore not initialized\n"); return rc; } -- 2.34.1
| |