lkml.org 
[lkml]   [2022]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] phy: mediatek: tphy: add debugfs files
From
Il 28/09/22 11:30, Chunfeng Yun ha scritto:
> These debugfs files are mainly used to make eye diagram test easier,
> especially helpful to do HQA test for a new IC without efuse enabled.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

Even though this won't be interesting for the vast majority of the people
out there (the users!), it's still nice to have it for IC testing performed
directly on upstream, as that opens new possibilities for you and ODMs/OEMs,
so I agree on getting that code upstreamed.

For that reason, I think that the best approach for this one would be to
enclose it in a configuration option like CONFIG_PHY_MTK_TPHY_DEBUGFS or
CONFIG_PHY_MTK_TPHY_DEBUG, so that this very low level debugging code
doesn't end up in end-user builds, as that may, in some cases, be even
dangerous.

Regards,
Angelo

\
 
 \ /
  Last update: 2022-09-28 15:36    [W:0.034 / U:1.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site