Messages in this thread | | | Date | Wed, 28 Sep 2022 21:27:40 +0800 (GMT+08:00) | From | duoming@zju ... | Subject | Re: [PATCH V3] mISDN: fix use-after-free bugs in l1oip timer handlers |
| |
Hello,
On Tue, 27 Sep 2022 17:26:18 -0700 Jakub Kicinski wrote:
> On Sat, 24 Sep 2022 10:18:42 +0800 Duoming Zhou wrote: > > + del_timer_sync(&hc->keep_tl); > > + del_timer_sync(&hc->timeout_tl); > > + cancel_work_sync(&hc->workq); > > + del_timer_sync(&hc->keep_tl); > > cancel_work_sync(&hc->workq); > > Why not add a bit which will indicate that the device is shutting > down and check it in places which schedule the timer? > I think that's much easier to reason about and we won't need to do > this rep cancel procedure.
Thank you for your time and suggestions!
Best regards, Duoming Zhou
| |