Messages in this thread | | | Date | Wed, 28 Sep 2022 13:12:59 +0200 | Subject | Re: [PATCH v2 2/2] dt-bindings: arm: add xiaomi,sagit board based on msm8998 chip | From | Krzysztof Kozlowski <> |
| |
On 28/09/2022 12:33, Dzmitry Sankouski wrote:
Missing commit msg.
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> > To: linux-kernel@vger.kernel.org > CC: Andy Gross <agross@kernel.org> (maintainer:ARM/QUALCOMM SUPPORT) > CC: Bjorn Andersson <bjorn.andersson@linaro.org> (maintainer:ARM/QUALCOMM SUPPORT) > CC: Konrad Dybcio <konrad.dybcio@somainline.org> (reviewer:ARM/QUALCOMM SUPPORT) > CC: Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) > CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) > CC: linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT) > CC: devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
None of these go to commit msg. Remove leaving only your SoB.
> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index fb1d00bcc847..00e51d22aeb1 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -76,6 +76,7 @@ description: | > mtp > qrd > sbc > + sagit
You do not use this way of compatibles, so don't extend it.
> > The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor> > where the minor number may be omitted when it's zero, i.e. v1.0 is the same > @@ -239,6 +240,7 @@ properties: > - sony,xperia-lilac > - sony,xperia-maple > - sony,xperia-poplar > + - xiaomi,sagit > - const: qcom,msm8998 > > - items:
Best regards, Krzysztof
| |