Messages in this thread | | | Date | Wed, 28 Sep 2022 11:47:11 +0100 | Subject | Re: [PATCH v4 2/2] perf: arm_cspmu: Add support for NVIDIA SCF and MCF attribute | From | Suzuki K Poulose <> |
| |
On 28/09/2022 02:38, Besar Wicaksono wrote: > > >> -----Original Message----- >> From: Suzuki K Poulose <suzuki.poulose@arm.com> >> Sent: Tuesday, September 27, 2022 6:43 AM >> To: Besar Wicaksono <bwicaksono@nvidia.com>; robin.murphy@arm.com; >> catalin.marinas@arm.com; will@kernel.org; mark.rutland@arm.com >> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; >> linux-tegra@vger.kernel.org; sudeep.holla@arm.com; >> thanu.rangarajan@arm.com; Michael.Williams@arm.com; Thierry Reding >> <treding@nvidia.com>; Jonathan Hunter <jonathanh@nvidia.com>; Vikram >> Sethi <vsethi@nvidia.com>; mathieu.poirier@linaro.org; >> mike.leach@linaro.org; leo.yan@linaro.org >> Subject: Re: [PATCH v4 2/2] perf: arm_cspmu: Add support for NVIDIA SCF >> and MCF attribute >> >> External email: Use caution opening links or attachments >> >> >> On 14/08/2022 19:23, Besar Wicaksono wrote: >>> Add support for NVIDIA System Cache Fabric (SCF) and Memory Control >>> Fabric (MCF) PMU attributes for CoreSight PMU implementation in >>> NVIDIA devices. >>> >>> Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>
>>> +struct nv_cspmu_match { >>> + u32 prodid; >>> + u32 prodid_mask; >>> + u64 filter_mask; >>> + const char *name_pattern; >>> + enum nv_cspmu_name_fmt name_fmt; >>> + struct attribute **event_attr; >>> + struct attribute **format_attr; >>> +}; >>> + >>> +static const struct nv_cspmu_match nv_cspmu_match[] = { >> >> Similar coding style nit below. >> > > Sure, I will update this. > >> >> Otherwise, >> >> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> > > Thanks! > > Unfortunately, we need to update the name of the PMUs and remove > some of the attributes in NVIDIA implementation. This requires a change > in nvidia_cspmu.c and nvidia-pmu.rst. I hope you are fine if I include this > change on v5 patch.
That should be fine.
Suzuki
| |