lkml.org 
[lkml]   [2022]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] btrfs:remove redundant index_rbio_pages in raid56_rmw_stripe
From


On 9/28/22 21:44, Flint.Wang wrote:
> The index_rbio_pages in raid56_rmw_stripe is redundant.
> It is invoked in finish_rmw anyway.
>
> Signed-off-by: Flint.Wang <hmsjwzb@zoho.com>
> ---
> fs/btrfs/raid56.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
> index f6395e8288d69..44266b2c5b86e 100644
> --- a/fs/btrfs/raid56.c
> +++ b/fs/btrfs/raid56.c
> @@ -1546,8 +1546,6 @@ static int raid56_rmw_stripe(struct btrfs_raid_bio *rbio)
> if (ret)
> goto cleanup;
>
> - index_rbio_pages(rbio);
> -
> atomic_set(&rbio->error, 0);
> /* Build a list of bios to read all the missing data sectors. */
> for (total_sector_nr = 0; total_sector_nr < nr_data_sectors;
Hi Qu,

I am doing some experiment on the destroy RMW. It seems the index_rbio_pages in raid56_rmw_stripe is redundant. We will do it in finish_rmw anyway.

Thanks,
Flint

\
 
 \ /
  Last update: 2022-09-29 03:50    [W:0.067 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site