Messages in this thread | | | Subject | Re: [PATCH v2] clk: iproc: Do not rely on node name for correct PLL setup | From | Stephen Boyd <> | Date | Wed, 28 Sep 2022 18:33:36 -0700 |
| |
Quoting Florian Fainelli (2022-09-05 09:15:03) > After commit 31fd9b79dc58 ("ARM: dts: BCM5301X: update CRU block > description") a warning from clk-iproc-pll.c was generated due to a > duplicate PLL name as well as the console stopped working. Upon closer > inspection it became clear that iproc_pll_clk_setup() used the Device > Tree node unit name as an unique identifier as well as a parent name to > parent all clocks under the PLL. > > BCM5301X was the first platform on which that got noticed because of the > DT node unit name renaming but the same assumptions hold true for any > user of the iproc_pll_clk_setup() function. > > The first 'clock-output-names' property is always guaranteed to be > unique as well as providing the actual desired PLL clock name, so we > utilize that to register the PLL and as a parent name of all children > clock. > > Fixes: 5fe225c105fd ("clk: iproc: add initial common clock support") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > Acked-by: Rafał Miłecki <rafal@milecki.pl> > ---
Applied to clk-fixes
| |