lkml.org 
[lkml]   [2022]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v9 1/7] dt-bindings: remoteproc: qcom: Add SC7280 ADSP support
From
On 27/09/2022 15:56, Srinivasa Rao Mandadapu wrote:
> Add ADSP PIL loading support for SC7280 SoCs.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> ---

Thank you for your patch. There is something to discuss/improve.

> + qcom,smem-state-names:
> + description: The names of the state bits used for SMP2P output
> + const: stop
> +
> + qcom,qmp:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Reference to the AOSS side-channel message RAM.
> +
> + glink-edge:
> + $ref: qcom,glink-edge.yaml#
> + type: object

You still miss here unevaluatedProperties: false on this level of
indentation.

> + description: |
> + Qualcomm G-Link subnode which represents communication edge, channels
> + and devices related to the ADSP.
> +
Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-28 08:59    [W:0.048 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site