lkml.org 
[lkml]   [2022]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH mm-unstable v15 08/14] mm: multi-gen LRU: support page table walks
    Hi Andrew,

    Can you please take another fixlet? Thanks.

    Don't sync disk for each aging cycle.

    wakeup_flusher_threads() was added under the assumption that if a
    system runs out of clean cold pages, it might want to write back dirty
    pages more aggressively so that they can become clean and be dropped.

    However, doing so can breach the rate limit a system wants to impose
    on writeback, resulting in early SSD wearout.

    Reported-by: Axel Rasmussen <axelrasmussen@google.com>
    Signed-off-by: Yu Zhao <yuzhao@google.com>
    ---
    mm/vmscan.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/mm/vmscan.c b/mm/vmscan.c
    index 5b565470286b..0317d4cf4884 100644
    --- a/mm/vmscan.c
    +++ b/mm/vmscan.c
    @@ -4413,8 +4413,6 @@ static bool try_to_inc_max_seq(struct lruvec *lruvec, unsigned long max_seq,
    if (wq_has_sleeper(&lruvec->mm_state.wait))
    wake_up_all(&lruvec->mm_state.wait);

    - wakeup_flusher_threads(WB_REASON_VMSCAN);
    -
    return true;
    }

    --
    2.37.3.998.g577e59143f-goog
    \
     
     \ /
      Last update: 2022-09-28 21:38    [W:2.900 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site