lkml.org 
[lkml]   [2022]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 17/29] thermal/of: Remove of_thermal_is_trip_valid()
    Date
    There is no benefit with the of_thermal_is_trip_valid() function as it
    does the check the thermal_zone_get_trip() is already doing for the
    sake of getting the trip point.

    As all the calls have been replaced by thermal_zone_get_trip(), there
    is no more users of of_thermal_is_trip_valid().

    Remove the function.

    Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    ---
    drivers/thermal/thermal_core.h | 10 ----------
    drivers/thermal/thermal_of.c | 19 -------------------
    2 files changed, 29 deletions(-)

    diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
    index b00fc1913734..e9b3af6c2084 100644
    --- a/drivers/thermal/thermal_core.h
    +++ b/drivers/thermal/thermal_core.h
    @@ -138,16 +138,6 @@ thermal_cooling_device_stats_update(struct thermal_cooling_device *cdev,
    #endif /* CONFIG_THERMAL_STATISTICS */

    /* device tree support */
    -#ifdef CONFIG_THERMAL_OF
    -bool of_thermal_is_trip_valid(struct thermal_zone_device *, int);
    -#else
    -static inline bool of_thermal_is_trip_valid(struct thermal_zone_device *tz,
    - int trip)
    -{
    - return false;
    -}
    -#endif
    -
    int thermal_zone_device_is_enabled(struct thermal_zone_device *tz);

    #endif /* __THERMAL_CORE_H__ */
    diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
    index 89afa59c4915..4e54d62720dc 100644
    --- a/drivers/thermal/thermal_of.c
    +++ b/drivers/thermal/thermal_of.c
    @@ -19,25 +19,6 @@

    #include "thermal_core.h"

    -/**
    - * of_thermal_is_trip_valid - function to check if trip point is valid
    - *
    - * @tz: pointer to a thermal zone
    - * @trip: trip point to evaluate
    - *
    - * This function is responsible for checking if passed trip point is valid
    - *
    - * Return: true if trip point is valid, false otherwise
    - */
    -bool of_thermal_is_trip_valid(struct thermal_zone_device *tz, int trip)
    -{
    - if (trip >= tz->num_trips || trip < 0)
    - return false;
    -
    - return true;
    -}
    -EXPORT_SYMBOL_GPL(of_thermal_is_trip_valid);
    -
    static int of_thermal_set_trip_hyst(struct thermal_zone_device *tz, int trip,
    int hyst)
    {
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-09-27 16:35    [W:3.562 / U:0.808 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site