lkml.org 
[lkml]   [2022]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 04/17] dt-bindings: display: mediatek: add MT8195 hdmi bindings
From
On 27/09/2022 15:54, Guillaume Ranquet wrote:
> On Thu, 22 Sep 2022 09:18, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> On 19/09/2022 18:56, Guillaume Ranquet wrote:
>>> Add mt8195 SoC bindings for hdmi and hdmi-ddc
>>>
>>> Make port1 optional for mt8195 as it only supports HDMI tx for now.
>>> Requires a ddc-i2c-bus phandle.
>>> Requires a power-domains phandle.
>>>
>>> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml
>>> index bdaf0b51e68c..abb231a0694b 100644
>>> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml
>>> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml
>>> @@ -21,6 +21,10 @@ properties:
>>> - mediatek,mt7623-hdmi
>>> - mediatek,mt8167-hdmi
>>> - mediatek,mt8173-hdmi
>>> + - mediatek,mt8195-hdmi
>>> +
>>> + clocks: true
>>> + clock-names: true
>>
>> ????
>> Why is this moved?
>>
>>>
>>> reg:
>>> maxItems: 1
>>> @@ -28,20 +32,6 @@ properties:
>>> interrupts:
>>> maxItems: 1
>>>
>>> - clocks:
>>> - items:
>>> - - description: Pixel Clock
>>> - - description: HDMI PLL
>>> - - description: Bit Clock
>>> - - description: S/PDIF Clock
>>> -
>>> - clock-names:
>>> - items:
>>> - - const: pixel
>>> - - const: pll
>>> - - const: bclk
>>> - - const: spdif
>>
>> Clock definition with constraints should stay here. You just customize
>> it per variant.
>>
> Clocks are different between the two hardwares, so I've tried moving everything
> inside the if/else block.
>
> Is there a better way to express this?

https://elixir.bootlin.com/linux/v5.19-rc6/source/Documentation/devicetree/bindings/clock/samsung,exynos7-clock.yaml#L38

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-27 16:33    [W:0.092 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site