lkml.org 
[lkml]   [2022]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] iommu/io-pgtable: Make IOMMU_IO_PGTABLE_DART invisible
From
On 2022-09-27 14:36, Geert Uytterhoeven wrote:
> There is no point in asking the user about both "Apple DART Formats" and
> "Apple DART IOMMU Support", as the former is useless without the latter,
> and the latter auto-selects the former.
>
> Fixes: 745ef1092bcfcf3b ("iommu/io-pgtable: Move Apple DART support to its own file")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Should IOMMU_IO_PGTABLE_LPAE and IOMMU_IO_PGTABLE_ARMV7S be made
> invisible, too?
> Are there users that do not select them?

The aim was for formats to be independently selectable for COMPILE_TEST
coverage. The Arm formats are manually selectable for the sake of their
runtime self-tests, which are self-contained, but since DART format
doesn't do anything by itself I'd agree there's no need to prompt when
!COMPILE_TEST here.

Thanks,
Robin.

> ---
> drivers/iommu/Kconfig | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index dc5f7a156ff5ec73..f1affca6022e0a54 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -68,16 +68,13 @@ config IOMMU_IO_PGTABLE_ARMV7S_SELFTEST
> If unsure, say N here.
>
> config IOMMU_IO_PGTABLE_DART
> - bool "Apple DART Formats"
> + bool
> select IOMMU_IO_PGTABLE
> - depends on ARM64 || (COMPILE_TEST && !GENERIC_ATOMIC64)
> help
> Enable support for the Apple DART pagetable formats. These include
> the t8020 and t6000/t8110 DART formats used in Apple M1/M2 family
> SoCs.
>
> - If unsure, say N here.
> -
> endmenu
>
> config IOMMU_DEBUGFS

\
 
 \ /
  Last update: 2022-09-27 16:16    [W:0.080 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site