Messages in this thread | | | Date | Tue, 27 Sep 2022 15:57:08 +0200 | Subject | Re: [PATCH 25/32] dt-bindings: pinctrl: qcom,qcm2290: do not require function on non-GPIOs | From | Krzysztof Kozlowski <> |
| |
On 27/09/2022 13:42, Dmitry Baryshkov wrote: > On Sat, 24 Sept 2022 at 11:07, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> Certain pins, like SDcard related, do not have functions and such should >> not be required. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../bindings/pinctrl/qcom,qcm2290-pinctrl.yaml | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml >> index 5324b61eb4f7..89453cb60c12 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml >> @@ -60,7 +60,6 @@ patternProperties: >> description: >> Pinctrl node's client devices use subnodes for desired pin configuration. >> Client device subnodes use below standard properties. >> - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" >> >> properties: >> pins: >> @@ -116,6 +115,16 @@ patternProperties: >> required: >> - pins >> >> + allOf: > > Nit: I think you can drop allOf here and move the $ref up a few lines. >
It's anyway different in v2 - there is no if:then.
Best regards, Krzysztof
| |