lkml.org 
[lkml]   [2022]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 03/15] arm64: dts: qcom: sc8280xp: align TLMM pin configuration with DT schema
    From


    On 25.09.2022 13:05, Krzysztof Kozlowski wrote:
    > DT schema expects TLMM pin configuration nodes to be named with
    > '-state' suffix and their optional children with '-pins' suffix.
    >
    > qcom/sc8280xp-crd.dtb: pinctrl@f100000: kybd-default-state: 'oneOf' conditional failed, one must be fixed:
    > 'pins' is a required property
    > 'function' is a required property
    > 'disable', 'int-n', 'reset' do not match any of the regexes: 'pinctrl-[0-9]+'
    > 'disable', 'int-n', 'reset' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
    >
    > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    > ---
    Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>

    Konrad
    > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 12 ++++++------
    > .../boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 12 ++++++------
    > 2 files changed, 12 insertions(+), 12 deletions(-)
    >
    > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
    > index fea7d8273ccd..a2027f1d1d04 100644
    > --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
    > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
    > @@ -374,19 +374,19 @@ &tlmm {
    > gpio-reserved-ranges = <74 6>, <83 4>, <125 2>, <128 2>, <154 7>;
    >
    > kybd_default: kybd-default-state {
    > - disable {
    > + disable-pins {
    > pins = "gpio102";
    > function = "gpio";
    > output-low;
    > };
    >
    > - int-n {
    > + int-n-pins {
    > pins = "gpio104";
    > function = "gpio";
    > bias-disable;
    > };
    >
    > - reset {
    > + reset-pins {
    > pins = "gpio105";
    > function = "gpio";
    > bias-disable;
    > @@ -410,7 +410,7 @@ qup2_i2c5_default: qup2-i2c5-default-state {
    > };
    >
    > tpad_default: tpad-default-state {
    > - int-n {
    > + int-n-pins {
    > pins = "gpio182";
    > function = "gpio";
    > bias-disable;
    > @@ -418,13 +418,13 @@ int-n {
    > };
    >
    > ts0_default: ts0-default-state {
    > - int-n {
    > + int-n-pins {
    > pins = "gpio175";
    > function = "gpio";
    > bias-disable;
    > };
    >
    > - reset-n {
    > + reset-n-pins {
    > pins = "gpio99";
    > function = "gpio";
    > output-high;
    > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
    > index b2b744bb8a53..68b61e8d03c0 100644
    > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
    > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
    > @@ -350,19 +350,19 @@ &tlmm {
    > gpio-reserved-ranges = <70 2>, <74 6>, <83 4>, <125 2>, <128 2>, <154 7>;
    >
    > kybd_default: kybd-default-state {
    > - disable {
    > + disable-pins {
    > pins = "gpio102";
    > function = "gpio";
    > output-low;
    > };
    >
    > - int-n {
    > + int-n-pins {
    > pins = "gpio104";
    > function = "gpio";
    > bias-disable;
    > };
    >
    > - reset {
    > + reset-pins {
    > pins = "gpio105";
    > function = "gpio";
    > bias-disable;
    > @@ -384,7 +384,7 @@ qup2_i2c5_default: qup2-i2c5-default-state {
    > };
    >
    > tpad_default: tpad-default-state {
    > - int-n {
    > + int-n-pins {
    > pins = "gpio182";
    > function = "gpio";
    > bias-disable;
    > @@ -392,13 +392,13 @@ int-n {
    > };
    >
    > ts0_default: ts0-default-state {
    > - int-n {
    > + int-n-pins {
    > pins = "gpio175";
    > function = "gpio";
    > bias-disable;
    > };
    >
    > - reset-n {
    > + reset-n-pins {
    > pins = "gpio99";
    > function = "gpio";
    > output-high;

    \
     
     \ /
      Last update: 2022-09-27 14:43    [W:4.349 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site