Messages in this thread | | | Subject | Re: [PATCH] checkpatch: Don't count URLs for "line too long" | From | Joe Perches <> | Date | Mon, 26 Sep 2022 22:40:50 -0700 |
| |
On Mon, 2022-09-26 at 19:15 -0700, Kees Cook wrote: > URLs (not in a Link: field) should be ignored for "line too long" > warnings. Allow any line containing "https://" or "http://".
More generally, this should be for any URI
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -3175,6 +3175,8 @@ sub process { > # file delta changes > $line =~ /^\s*(?:[\w\.\-\+]*\/)++[\w\.\-\+]+:/ || > # filename then : > + $line =~ /https?:\/\// || > + # URLs > $line =~ /^\s*(?:Fixes:|Link:|$signature_tags)/i || > # A Fixes: or Link: line or signature tag line > $commit_log_possible_stack_dump)) {
And I don't recollect why this wasn't applied, but I think it's a rather better, more complete, patch:
https://lore.kernel.org/lkml/20210114073513.15773-2-yashsri421@gmail.com/
I believe I did ack it and forward it to Andrew Morton, but I don't see it on a lore list.
| |