lkml.org 
[lkml]   [2022]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] arm64: dts: mt8192: Add vcodec lat and core nodes
From
Il 27/09/22 04:19, Allen-KH Cheng (程冠勳) ha scritto:
> Hi Angelo,
>
> On Mon, 2022-09-26 at 17:29 +0200, AngeloGioacchino Del Regno wrote:
>> Il 26/09/22 12:50, Allen-KH Cheng ha scritto:
>>> Add vcodec lat and core nodes for mt8192 SoC.
>>>
>>> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
>>> Tested-by: Chen-Yu Tsai <wenst@chromium.org>
>>> ---
>>> Change in v1:
>>> * Replace node names with video-codec
>>> [Allen-KH Cheng <allen-kh.cheng@mediatek.com>]
>>> ---
>>> ---
>>> arch/arm64/boot/dts/mediatek/mt8192.dtsi | 60
>>> ++++++++++++++++++++++++
>>> 1 file changed, 60 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
>>> b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
>>> index 6b20376191a7..214dfc6b0ed1 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
>>> @@ -1449,6 +1449,66 @@
>>> power-domains = <&spm
>>> MT8192_POWER_DOMAIN_ISP2>;
>>> };
>>>
>>> + vcodec_dec: video-codec@16000000 {
>>> + compatible = "mediatek,mt8192-vcodec-dec";
>>> + reg = <0 0x16000000 0 0x1000>;
>>> + mediatek,scp = <&scp>;
>>> + iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>;
>>> + dma-ranges = <0x1 0x0 0x0 0x40000000 0x0
>>> 0xfff00000>;
>>> + #address-cells = <2>;
>>> + #size-cells = <2>;
>>> + ranges = <0 0 0 0x16000000 0 0x26000>;
>>> +
>>> + vcodec_lat: video-codec@10000 {
>>
>> Allen, this won't work :-(
>> Check Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
>> decoder.yaml
>> ...the schema requires vcodec-lat@[0-9a-f] and vcodec-core@[0-9a-f].
>>
>> If you want to call them all video-codec@addr, you have to also fix
>> the schema.
>>
>> P.S.: Did you try to run `make dtbs_check`?
>>
>> Regards,
>> Angelo
>>
>
> Sorry, my bad. I alsways run `make dtbs_check` to confirm dtb with
> bindings. I just think we didn't limit node names in mtk-vodec
> bindings. I will pay attention next time.
>
>
> Since currently the vcodec lat and core nodes are absent from the mtk
> dts, do you think the child node name should be changed to something
> more general (ex: video-codec) in mediatek,vcodec-subdev-decoder
> bindings?

The video codec is mt8192-vcodec-dec, while the other nodes are describing
the VPU instances (and/or vpu cores)... I'm not sure.

Krzysztof, please, can you give your opinion on that?

Regards,
Angelo

>
> Thanks,
> Allen
>
>
>
>
>

\
 
 \ /
  Last update: 2022-09-27 12:18    [W:0.062 / U:1.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site