Messages in this thread | | | From | Mattijs Korpershoek <> | Subject | Re: [PATCH v2 RESEND] input: keyboard: snvs_pwrkey: Fix SNVS_HPVIDR1 register address | Date | Tue, 27 Sep 2022 10:12:48 +0200 |
| |
On Tue, Sep 27, 2022 at 08:25, Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm> wrote:
> Both i.MX6 and i.MX8 reference manuals list 0xBF8 as SNVS_HPVIDR1 > (chapters 57.9 and 6.4.5 respectively). > > Without this, trying to read the revision number results in 0 on > all revisions, causing the i.MX6 quirk to apply on all platforms, > which in turn causes the driver to synthesise power button release > events instead of passing the real one as they happen even on > platforms like i.MX8 where that's not wanted. > > Fixes: 1a26c920717a ("Input: snvs_pwrkey - send key events for i.MX6 S, DL and Q") > Cc: <stable@vger.kernel.org> > Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm> > Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> --- > Resent <20220321171755.656750-1-sebastian.krzyszkowiak@puri.sm> > v2: augmented commit message; added cc: stable and tested-by > --- > drivers/input/keyboard/snvs_pwrkey.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/snvs_pwrkey.c > index 65286762b02a..ad8660be0127 100644 > --- a/drivers/input/keyboard/snvs_pwrkey.c > +++ b/drivers/input/keyboard/snvs_pwrkey.c > @@ -20,7 +20,7 @@ > #include <linux/mfd/syscon.h> > #include <linux/regmap.h> > > -#define SNVS_HPVIDR1_REG 0xF8 > +#define SNVS_HPVIDR1_REG 0xBF8 > #define SNVS_LPSR_REG 0x4C /* LP Status Register */ > #define SNVS_LPCR_REG 0x38 /* LP Control Register */ > #define SNVS_HPSR_REG 0x14 > -- > 2.35.1
| |