Messages in this thread | | | From | Thomas Tai <> | Subject | RE: [PATCH] x86/sgx: Add code to inject hwpoison into SGX memory | Date | Tue, 27 Sep 2022 21:41:04 +0000 |
| |
> -----Original Message----- > From: Luck, Tony <tony.luck@intel.com> > Sent: September 27, 2022 4:35 PM > To: Thomas Tai <thomas.tai@oracle.com>; dave.hansen@linux.intel.com; > jarkko@kernel.org; reinette.chatre@intel.co; naoya.horiguchi@nec.com; > linmiaohe@huawei.com; akpm@linux-foundation.org; linux-mm@kvack.org; > linux-kernel@vger.kernel.org; Thomas Tai <thomas.tai@oracle.com> > Subject: RE: [PATCH] x86/sgx: Add code to inject hwpoison into SGX memory > > > Inspired by commit c6acb1e7bf46 (x86/sgx: Add hook to error injection > > address validation), add a similar code in hwpoison_inject function to > > check if the address is located in SGX Memory. The error will then be > > handled by the arch_memory_failure function in the SGX driver. > > Looks good to me. > > [I wish that Linux hadn't called this "hwpoison_inject()" because there's nothing > hardware related about this injection. But you are just an innocent consumer of > that poor naming choice] > > Reviewed-by: Tony Luck <tony.luck@intel.com>
Thanks, Tony, for your review.
Cheers, Thomas
> > -Tony
| |