lkml.org 
[lkml]   [2022]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] x86/sgx: Add code to inject hwpoison into SGX memory
Date
> -----Original Message-----
> From: Luck, Tony <tony.luck@intel.com>
> Sent: September 27, 2022 4:35 PM
> To: Thomas Tai <thomas.tai@oracle.com>; dave.hansen@linux.intel.com;
> jarkko@kernel.org; reinette.chatre@intel.co; naoya.horiguchi@nec.com;
> linmiaohe@huawei.com; akpm@linux-foundation.org; linux-mm@kvack.org;
> linux-kernel@vger.kernel.org; Thomas Tai <thomas.tai@oracle.com>
> Subject: RE: [PATCH] x86/sgx: Add code to inject hwpoison into SGX memory
>
> > Inspired by commit c6acb1e7bf46 (x86/sgx: Add hook to error injection
> > address validation), add a similar code in hwpoison_inject function to
> > check if the address is located in SGX Memory. The error will then be
> > handled by the arch_memory_failure function in the SGX driver.
>
> Looks good to me.
>
> [I wish that Linux hadn't called this "hwpoison_inject()" because there's nothing
> hardware related about this injection. But you are just an innocent consumer of
> that poor naming choice]
>
> Reviewed-by: Tony Luck <tony.luck@intel.com>

Thanks, Tony, for your review.

Cheers,
Thomas

>
> -Tony

\
 
 \ /
  Last update: 2022-09-27 23:44    [W:0.139 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site