Messages in this thread | | | Date | Wed, 28 Sep 2022 02:23:25 +0800 | From | Chih-En Lin <> | Subject | Re: [RFC PATCH v2 3/9] mm, pgtable: Add ownership to PTE table |
| |
On Tue, Sep 27, 2022 at 05:30:39PM +0000, Nadav Amit wrote: > > +static inline void set_cow_pte_owner(pmd_t *pmd, pmd_t *owner) > > +{ > > + smp_store_release(&pmd_page(*pmd)->cow_pte_owner, owner); > > +} > > + > > +static inline bool cow_pte_owner_is_same(pmd_t *pmd, pmd_t *owner) > > +{ > > + return smp_load_acquire(&pmd_page(*pmd)->cow_pte_owner) == owner; > > +} > > Hiding synchronization primitives in such manner, and especially without > proper comments, makes it hard to understand what the ordering is supposed > to achieve. >
It ensures that every time we write into the pointer, the reader will ebserve the newest one. I will add the comments.
Thanks, Chih-En Lin
| |