lkml.org 
[lkml]   [2022]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH v5 0/6] Provide SEV-SNP support for unaccepted memory
    Date
    This series adds SEV-SNP support for unaccepted memory to the patch series
    titled:

    [PATCHv7 00/14] mm, x86/cc: Implement support for unaccepted memory

    Currently, when changing the state of a page under SNP, the page state
    change structure is kmalloc()'d. This lead to hangs during boot when
    accepting memory because the allocation can trigger the need to accept
    more memory. Additionally, the page state change operations are not
    optimized under Linux since it was expected that all memory has been
    validated already, resulting in poor performance when adding basic
    support for unaccepted memory.

    This series consists of six patches:
    - Two pre-patch fixes which can be taken regardless of this series.

    - A pre-patch to switch from a kmalloc()'d page state change structure
    to a (smaller) stack-based page state change structure.

    - A pre-patch to allow the use of the early boot GHCB in the core kernel
    path.

    - A pre-patch to allow for use of 2M page state change requests and 2M
    page validation.

    - SNP support for unaccepted memory.

    The series is based off of and tested against Kirill Shutemov's tree:
    https://github.com/intel/tdx.git guest-unaccepted-memory

    ---

    Changes since v4:
    - Two fixes for when an unsigned int used as the number of pages to
    process, it needs to be converted to an unsigned long before being
    used to calculate ending addresses, otherwise a value >= 0x100000
    results in adding 0 in the calculation.
    - Commit message and comment updates.

    Changes since v3:
    - Reworks the PSC process to greatly improve performance:
    - Optimize the PSC process to use 2M pages when applicable.
    - Optimize the page validation process to use 2M pages when applicable.
    - Use the early GHCB in both the decompression phase and core kernel
    boot phase in order to minimize the use of the MSR protocol. The MSR
    protocol only allows for a single 4K page to be updated at a time.
    - Move the ghcb_percpu_ready flag into the sev_config structure and
    rename it to ghcbs_initialized.

    Changes since v2:
    - Improve code comments in regards to when to use the per-CPU GHCB vs
    the MSR protocol and why a single global value is valid for both
    the BSP and APs.
    - Add a comment related to the number of PSC entries and how it can
    impact the size of the struct and, therefore, stack usage.
    - Add a WARN_ON_ONCE() for invoking vmgexit_psc() when per-CPU GHCBs
    haven't been created or registered, yet.
    - Use the compiler support for clearing the PSC struct instead of
    issuing memset().

    Changes since v1:
    - Change from using a per-CPU PSC structure to a (smaller) stack PSC
    structure.


    Tom Lendacky (6):
    x86/sev: Fix calculation of end address based on number of pages
    x86/sev: Fix calculation of end address based on number of pages
    x86/sev: Put PSC struct on the stack in prep for unaccepted memory
    support
    x86/sev: Allow for use of the early boot GHCB for PSC requests
    x86/sev: Use large PSC requests if applicable
    x86/sev: Add SNP-specific unaccepted memory support

    arch/x86/Kconfig | 1 +
    arch/x86/boot/compressed/mem.c | 3 +
    arch/x86/boot/compressed/sev.c | 54 ++++++-
    arch/x86/boot/compressed/sev.h | 23 +++
    arch/x86/include/asm/sev-common.h | 9 +-
    arch/x86/include/asm/sev.h | 7 +
    arch/x86/kernel/sev-shared.c | 104 +++++++++++++
    arch/x86/kernel/sev.c | 250 +++++++++++++-----------------
    arch/x86/mm/unaccepted_memory.c | 4 +
    9 files changed, 307 insertions(+), 148 deletions(-)
    create mode 100644 arch/x86/boot/compressed/sev.h

    --
    2.37.3

    \
     
     \ /
      Last update: 2022-09-27 19:06    [W:4.490 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site