lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 037/148] media: flexcop-usb: fix endpoint type check
    Date
    From: Johan Hovold <johan@kernel.org>

    commit 763679f0eeff0185fc431498849bbc1c24460875 upstream.

    Commit d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint
    type") tried to add an endpoint type sanity check for the single
    isochronous endpoint but instead broke the driver by checking the wrong
    descriptor or random data beyond the last endpoint descriptor.

    Make sure to check the right endpoint descriptor.

    Fixes: d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint type")
    Cc: Oliver Neukum <oneukum@suse.com>
    Cc: stable@vger.kernel.org # 5.9
    Reported-by: Dongliang Mu <mudongliangabcd@gmail.com>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Link: https://lore.kernel.org/r/20220822151027.27026-1-johan@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/usb/b2c2/flexcop-usb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/media/usb/b2c2/flexcop-usb.c
    +++ b/drivers/media/usb/b2c2/flexcop-usb.c
    @@ -511,7 +511,7 @@ static int flexcop_usb_init(struct flexc

    if (fc_usb->uintf->cur_altsetting->desc.bNumEndpoints < 1)
    return -ENODEV;
    - if (!usb_endpoint_is_isoc_in(&fc_usb->uintf->cur_altsetting->endpoint[1].desc))
    + if (!usb_endpoint_is_isoc_in(&fc_usb->uintf->cur_altsetting->endpoint[0].desc))
    return -ENODEV;

    switch (fc_usb->udev->speed) {

    \
     
     \ /
      Last update: 2022-09-26 13:16    [W:4.041 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site