Messages in this thread | | | Date | Mon, 26 Sep 2022 08:48:09 +0200 | Subject | Re: [PATCH 17/32] dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on non-GPIOs | From | Krzysztof Kozlowski <> |
| |
On 25/09/2022 16:00, Stephan Gerhold wrote: >> + allOf: >> + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" >> + - if: >> + properties: >> + pins: >> + pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-7])$" >> + then: >> + required: >> + - function >> > > Is it possible to place this into qcom,tlmm-common.yaml? If the pattern > is only used to make "function" required for GPIOs, then it should not > matter if it matches just the prefix ("^gpio") or the exact set of > allowed GPIO numbers. The definition of the "pins" property will already > take care of validating those.
Hm, very good idea.
> > Or are there some Qcom SoCs where a GPIO without "function" is valid?
Quick look at drivers says there is no such case. I can try adding it to common schema and look for errors.
Best regards, Krzysztof
| |