lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 17/32] dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on non-GPIOs
    From
    On 25/09/2022 16:00, Stephan Gerhold wrote:
    >> + allOf:
    >> + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
    >> + - if:
    >> + properties:
    >> + pins:
    >> + pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-7])$"
    >> + then:
    >> + required:
    >> + - function
    >>
    >
    > Is it possible to place this into qcom,tlmm-common.yaml? If the pattern
    > is only used to make "function" required for GPIOs, then it should not
    > matter if it matches just the prefix ("^gpio") or the exact set of
    > allowed GPIO numbers. The definition of the "pins" property will already
    > take care of validating those.

    Hm, very good idea.

    >
    > Or are there some Qcom SoCs where a GPIO without "function" is valid?

    Quick look at drivers says there is no such case. I can try adding it to
    common schema and look for errors.


    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-09-26 08:48    [W:3.765 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site