lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 028/141] usb: cdns3: fix issue with rearming ISO OUT endpoint
    Date
    From: Pawel Laszczak <pawell@cadence.com>

    [ Upstream commit b46a6b09fa056042a302b181a1941f0056944603 ]

    ISO OUT endpoint is enabled during queuing first usb request
    in transfer ring and disabled when TRBERR is reported by controller.
    After TRBERR and before next transfer added to TR driver must again
    reenable endpoint but does not.
    To solve this issue during processing TRBERR event driver must
    set the flag EP_UPDATE_EP_TRBADDR in priv_ep->flags field.

    Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
    cc: <stable@vger.kernel.org>
    Acked-by: Peter Chen <peter.chen@kernel.org>
    Signed-off-by: Pawel Laszczak <pawell@cadence.com>
    Link: https://lore.kernel.org/r/20220825062137.5766-1-pawell@cadence.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/cdns3/gadget.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
    index d0d4de80680f..e3a8b6c71aa1 100644
    --- a/drivers/usb/cdns3/gadget.c
    +++ b/drivers/usb/cdns3/gadget.c
    @@ -1692,6 +1692,7 @@ static int cdns3_check_ep_interrupt_proceed(struct cdns3_endpoint *priv_ep)
    ep_cfg &= ~EP_CFG_ENABLE;
    writel(ep_cfg, &priv_dev->regs->ep_cfg);
    priv_ep->flags &= ~EP_QUIRK_ISO_OUT_EN;
    + priv_ep->flags |= EP_UPDATE_EP_TRBADDR;
    }
    cdns3_transfer_completed(priv_dev, priv_ep);
    } else if (!(priv_ep->flags & EP_STALLED) &&
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-09-26 13:01    [W:4.108 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site