lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 047/120] tty: serial: atmel: Preserve previous USART mode if RS485 disabled
    Date
    From: Sergiu Moga <sergiu.moga@microchip.com>

    [ Upstream commit 692a8ebcfc24f4a5bea0eb2967e450f584193da6 ]

    Whenever the atmel_rs485_config() driver method would be called,
    the USART mode is reset to normal mode before even checking if
    RS485 flag is set, thus resulting in losing the previous USART
    mode in the case where the checking fails.

    Some tools, such as `linux-serial-test`, lead to the driver calling
    this method when doing the setup of the serial port: after setting the
    port mode (Hardware Flow Control, Normal Mode, RS485 Mode, etc.),
    `linux-serial-test` tries to enable/disable RS485 depending on
    the commandline arguments that were passed.

    Example of how this issue could reveal itself:
    When doing a serial communication with Hardware Flow Control through
    `linux-serial-test`, the tool would lead to the driver roughly doing
    the following:
    - set the corresponding bit to 1 (ATMEL_US_USMODE_HWHS bit in the
    ATMEL_US_MR register) through the atmel_set_termios() to enable
    Hardware Flow Control
    - disable RS485 through the atmel_config_rs485() method
    Thus, when the latter is called, the mode will be reset and the
    previously set bit is unset, leaving USART in normal mode instead of
    the expected Hardware Flow Control mode.

    This fix ensures that this reset is only done if the checking for
    RS485 succeeds and that the previous mode is preserved otherwise.

    Fixes: e8faff7330a35 ("ARM: 6092/1: atmel_serial: support for RS485 communications")
    Cc: stable <stable@kernel.org>
    Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
    Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
    Link: https://lore.kernel.org/r/20220824142902.502596-1-sergiu.moga@microchip.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/serial/atmel_serial.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
    index 44608a06bb2c..3bd93558b443 100644
    --- a/drivers/tty/serial/atmel_serial.c
    +++ b/drivers/tty/serial/atmel_serial.c
    @@ -306,9 +306,6 @@ static int atmel_config_rs485(struct uart_port *port,

    mode = atmel_uart_readl(port, ATMEL_US_MR);

    - /* Resetting serial mode to RS232 (0x0) */
    - mode &= ~ATMEL_US_USMODE;
    -
    if (rs485conf->flags & SER_RS485_ENABLED) {
    dev_dbg(port->dev, "Setting UART to RS485\n");
    if (rs485conf->flags & SER_RS485_RX_DURING_TX)
    @@ -318,6 +315,7 @@ static int atmel_config_rs485(struct uart_port *port,

    atmel_uart_writel(port, ATMEL_US_TTGR,
    rs485conf->delay_rts_after_send);
    + mode &= ~ATMEL_US_USMODE;
    mode |= ATMEL_US_USMODE_RS485;
    } else {
    dev_dbg(port->dev, "Setting UART to RS232\n");
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-09-26 12:41    [W:4.144 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site