lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings
    From
    On 26/09/2022 11:22, Krzysztof Kozlowski wrote:
    > On 25/09/2022 23:02, Luca Weiss wrote:
    >> pm8941-misc should be called 'extcon' and pm8941-coincell 'charger'.
    >>
    >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
    >> ---
    >> arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++--
    >> 1 file changed, 2 insertions(+), 2 deletions(-)
    >>
    >> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
    >> index 33517cccee01..01f14d5f314d 100644
    >> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
    >> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
    >> @@ -27,7 +27,7 @@ pwrkey@800 {
    >> bias-pull-up;
    >> };
    >>
    >> - usb_id: misc@900 {
    >> + usb_id: extcon@900 {
    >
    > Why? extcon is Linux specific name and should not be added to DTS.
    > Anything requires it?

    It matches the current dt bindings:

    Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml:
    <snip>
    "extcon@[0-9a-f]+$":

    type: object

    $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
    <snip>

    Neil

    >
    >
    > Best regards,
    > Krzysztof
    >

    \
     
     \ /
      Last update: 2022-09-26 12:05    [W:4.535 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site