Messages in this thread | | | Date | Mon, 26 Sep 2022 11:28:18 +0200 | From | Paul Kocialkowski <> | Subject | Re: [PATCH 1/8] dt-bindings: sun6i-a31-mipi-dphy: Add the interrupts property |
| |
Hi Samuel,
On Fri 12 Aug 22, 17:19, Samuel Holland wrote: > On 8/12/22 5:45 AM, Krzysztof Kozlowski wrote: > > On 12/08/2022 10:55, Samuel Holland wrote: > >> The sun6i DPHY can generate several interrupts, mostly for reporting > >> error conditions, but also for detecting BTA and UPLS sequences. > >> Document this capability in order to accurately describe the hardware. > >> > >> The DPHY has no interrupt number provided in the vendor documentation > >> because its interrupt line is shared with the DSI controller. > >> > >> Fixes: c25b84c00826 ("dt-bindings: display: Convert Allwinner DSI to a schema") > > > > I don't understand what is being fixed in that commit. That commit did > > not have interrupts in D-PHY, so what was broken by it? > > > > The Fixes tag annotates the commit which introduced a bug. > > The binding had a bug because it did not accurately describe the hardware.
[...]
Coming back to this series, I don't really get the point of introducing the interrupt in the bindings and the device-tree sources if the interrupt is not required for normal operation. I would just drop it.
I recall I was in the same situation for the MIPI CSI-2 controllers, which also have a dedicated interrupt but only useful for debugging/error reporting. I was asked not to introduce it back then, so I suppose the same should apply.
What do you think?
Cheers,
Paul
-- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com [unhandled content-type:application/pgp-signature] | |