Messages in this thread |  | | Date | Mon, 26 Sep 2022 10:47:02 +0200 | Subject | Re: [PATCH 12/15] dt-bindings: pinctrl: qcom,sm8250: fix matching pin config | From | Krzysztof Kozlowski <> |
| |
On 25/09/2022 13:06, Krzysztof Kozlowski wrote: > The TLMM pin controller follows generic pin-controller bindings, so > should have subnodes with '-state' and '-pins'. Otherwise the subnodes > (level one and two) are not properly matched. This method also unifies > the bindings with other Qualcomm TLMM and LPASS pinctrl bindings. > > The change causes indentation decrement, so the diff-hunk looks big, but > there are no functional changes in the subnode "properties" section. > The only difference there is removal of blank lines between common GPIO > pinconf properties. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 145 +++++++++--------- > 1 file changed, 75 insertions(+), 70 deletions(-) >
(...)
> + > + required: > + - pins > + > + allOf: > + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" > + - if: > + properties: > + pins: > + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9])$" > + then: > + required: > + - function
In my other patchset, I moved this if:then: to common schema, therefore this patch will be later rebased. All other patches in the patchset are free to go, so far.
Best regards, Krzysztof
|  |