lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] ARM: dts: qcom: pm8941: fix vadc channel node names
From
On 25/09/2022 18:18, Luca Weiss wrote:
> Node names for the channel are supposed to be adc-chan@REG.
>
> Use this format and at the same time sort the nodes by reg value.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom-pm8941.dtsi | 25 ++++++++++++++++---------
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index 9cd49deb9fa7..3c15eecf2f21 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -101,26 +101,33 @@ pm8941_vadc: adc@3100 {
> #size-cells = <0>;
> #io-channel-cells = <1>;
>
> - bat_temp {
> - reg = <VADC_LR_MUX1_BAT_THERM>;
> +
> + adc-chan@6 {
> + reg = <VADC_VBAT_SNS>;
> };
> - die_temp {
> +
> + adc-chan@8 {
> reg = <VADC_DIE_TEMP>;
> };
> - ref_625mv {
> +
> + adc-chan@9 {
> reg = <VADC_REF_625MV>;
> };
> - ref_1250v {
> +
> + adc-chan@10 {
> reg = <VADC_REF_1250MV>;
> };
> - ref_gnd {
> +
> + adc-chan@14 {
> reg = <VADC_GND_REF>;
> };
> - ref_vdd {
> +
> + adc-chan@15 {
> reg = <VADC_VDD_VADC>;
> };
> - vbat_sns {
> - reg = <VADC_VBAT_SNS>;
> +
> + adc-chan@48 {
> + reg = <VADC_LR_MUX1_BAT_THERM>;
> };
> };
>

Here aswell, I don't see where this is required, bindings doesn't mandate this naming:

patternProperties:

"^.*@[0-9a-f]+$":
Neil

\
 
 \ /
  Last update: 2022-09-26 10:45    [W:0.066 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site