lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] dt-bindings: clock: add QCOM SM6115 display clock bindings
On Tue, Sep 13, 2022 at 10:26:20AM -0500, Rob Herring wrote:
> On Sun, Sep 11, 2022 at 06:46:18PM +0200, Adam Skladowski wrote:
> > Add device tree bindings for display clock controller for
> > Qualcomm Technology Inc's SM6115 SoC.
> >
> > Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
> > ---
> > .../bindings/clock/qcom,sm6115-dispcc.yaml | 70 +++++++++++++++++++
> > .../dt-bindings/clock/qcom,sm6115-dispcc.h | 36 ++++++++++
> > 2 files changed, 106 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
> > create mode 100644 include/dt-bindings/clock/qcom,sm6115-dispcc.h
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
> > new file mode 100644
> > index 000000000000..a6bf363b5015
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
> > @@ -0,0 +1,70 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/qcom,sm6115-dispcc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Display Clock Controller Binding for SM6115
>
> s/Binding //
>
> > +
> > +maintainers:
> > + - Bjorn Andersson <andersson@kernel.org>
> > +
> > +description: |
>
> Don't need '|' when no formatting to preserve.
>

This follows the other dispcc bindings, where I think the intention is
to keep the formatting over "See also". In contrast to the other dispcc
bindings the "See also" has a ':' at the end in this proposal...

> With those fixes,
>
> Reviewed-by: Rob Herring <robh@kernel.org>

I took the liberty of fixing up the description to align with the others
and applied this, with your R-b.

Regards,
Bjorn

\
 
 \ /
  Last update: 2022-09-27 05:15    [W:0.059 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site