Messages in this thread |  | | Date | Mon, 26 Sep 2022 10:27:54 +0200 | Subject | Re: [PATCH] ARM: dts: qcom-pma8084: fix vadc channel node names | From | Neil Armstrong <> |
| |
On 25/09/2022 22:21, Luca Weiss wrote: > Node names for the channel are supposed to be adc-chan@REG. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > arch/arm/boot/dts/qcom-pma8084.dtsi | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-pma8084.dtsi b/arch/arm/boot/dts/qcom-pma8084.dtsi > index e77602e9f95c..7ad573c7b4ac 100644 > --- a/arch/arm/boot/dts/qcom-pma8084.dtsi > +++ b/arch/arm/boot/dts/qcom-pma8084.dtsi > @@ -64,22 +64,27 @@ pma8084_vadc: adc@3100 { > #size-cells = <0>; > #io-channel-cells = <1>; > > - die_temp { > + adc-chan@8 { > reg = <VADC_DIE_TEMP>; > }; > - ref_625mv { > + > + adc-chan@9 { > reg = <VADC_REF_625MV>; > }; > - ref_1250v { > + > + adc-chan@10 { > reg = <VADC_REF_1250MV>; > }; > - ref_buf_625mv { > + > + adc-chan@12 { > reg = <VADC_SPARE1>; > }; > - ref_gnd { > + > + adc-chan@14 { > reg = <VADC_GND_REF>; > }; > - ref_vdd { > + > + adc-chan@15 { > reg = <VADC_VDD_VADC>; > }; > };
I don't see where this is required, bindings doesn't mandate this naming:
patternProperties:
"^.*@[0-9a-f]+$": Neil
|  |