Messages in this thread | | | From | Vishal Annapurve <> | Date | Mon, 26 Sep 2022 16:32:43 -0700 | Subject | Re: [V2 PATCH 5/8] KVM: selftests: x86: delete svm_vmcall_test |
| |
On Wed, Sep 21, 2022 at 2:34 PM David Matlack <dmatlack@google.com> wrote: > > On Thu, Sep 15, 2022 at 12:04:45AM +0000, Vishal Annapurve wrote: > > svm_vmcall_test is superseded by fix_hypercall_test. > > Please provide a more detailed description of why svm_vmcall_test is > being dropped. e.g. What do you mean by "superseded" specifically? > > I ask because this will be helpful context for future readers of this > commit. I also ask because it's not clear to me that fix_hypercall_test > is a 1:1 replacement of svm_vmcall_test. e.g. svm_vmcall_test sets up an > L2 while fix_hypercall_test just executes in L1. >
You are right, I earlier wrongly interpreted it to be just testing vmcall, but it also does vmcall from L2. I will exclude this change in the next series.
> > > > Suggested-by: Sean Christopherson <seanjc@google.com> > > Signed-off-by: Vishal Annapurve <vannapurve@google.com> > > --- > > -- > > 2.37.2.789.g6183377224-goog > >
| |