Messages in this thread | | | From | Nick Desaulniers <> | Date | Mon, 26 Sep 2022 14:41:00 -0700 | Subject | Re: [PATCH v4] Makefile.compiler: replace cc-ifversion with compiler-specific macros |
| |
On Sat, Sep 24, 2022 at 6:23 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > > I noticed a small flaw now. > > > > > > > > $ make mrproper; make > > /bin/sh: 1: [: -ge: unexpected operator > > *** > > *** Configuration file ".config" not found! > > *** > > *** Please run some configurator (e.g. "make oldconfig" or > > *** "make menuconfig" or "make xconfig"). > > *** > > Makefile:711: include/config/auto.conf.cmd: No such file or directory > > make: *** [Makefile:720: .config] Error 1 > > > > > > > > > > > > > > > > > > This fails anyway, but it shows annoying > > > > /bin/sh: 1: [: -ge: unexpected operator > > > > > > > > It is emit by this line: > > > > KBUILD_CFLAGS-$(call gcc-min-version, 90100) += -Wno-alloc-size-larger-than > > > > > > > > > > When $(CONFIG_GCC_VERSION) is empty, it becomes invalid shell code: > > > > [ -ge $(1) ] && echo y > > > > > > > > > > > > Now I just recalled why I wrote the original code like this: > > > > > > cc-ifversion = $(shell [ $(CONFIG_GCC_VERSION)0 $(1) $(2)000 ] ... > > > > > > > > > > -- > > Best Regards > > Masahiro Yamada > > > > > > > > I squashed the following code diff. > Please let me know if there is a problem.
LGTM; thanks (again).
> > > > > > > > > > diff --git a/scripts/Makefile.compiler b/scripts/Makefile.compiler > index 9d18fb91890e..20d353dcabfb 100644 > --- a/scripts/Makefile.compiler > +++ b/scripts/Makefile.compiler > @@ -63,11 +63,11 @@ cc-disable-warning = $(call try-run,\ > > # gcc-min-version > # Usage: cflags-$(call gcc-min-version, 70100) += -foo > -gcc-min-version = $(shell [ $(CONFIG_GCC_VERSION) -ge $(1) ] && echo y) > +gcc-min-version = $(shell [ $(CONFIG_GCC_VERSION)0 -ge $(1)0 ] && echo y) > > # clang-min-version > # Usage: cflags-$(call clang-min-version, 110000) += -foo > -clang-min-version = $(shell [ $(CONFIG_CLANG_VERSION) -ge $(1) ] && echo y) > +clang-min-version = $(shell [ $(CONFIG_CLANG_VERSION)0 -ge $(1)0 ] && echo y) > > # ld-option > # Usage: KBUILD_LDFLAGS += $(call ld-option, -X, -Y) > > > > > > > -- > Best Regards > Masahiro Yamada >
-- Thanks, ~Nick Desaulniers
| |