lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[RESEND PATCH v1 0/4] Fixes for the mcp2221 HID-to-I2C-bridge driver
Date
In this patch series are fixes for issues I found during recent tests of
an MCP2221 board.

- you can confuse the kernel driver when using the chip from user mode
via /dev/hidrawX, typically leading to a NULL pointer dereference in
the driver's HID raw event handler

- the driver needs > 15s to initialize because the HID raw handling is
not enabled during initialization of the GPIO part

- data shared with the bottom half code is not protected from concurrent
access

- the rxbuf pointer can become invalid or even stale if the device would
send unsolicited reports

Enrik Berkhan (4):
HID: mcp2221: don't connect hidraw
HID: mcp2221: enable HID I/O during GPIO probe
HID: mcp2221: protect shared data with spin lock
HID: mcp2221: avoid stale rxbuf pointer

drivers/hid/hid-mcp2221.c | 114 ++++++++++++++++++++++++++++++++------
1 file changed, 97 insertions(+), 17 deletions(-)
---

Resend because I had a typo in the linux-input mailing list address.
Also adding linux-kernel to increase visibility.

--
2.34.1

\
 
 \ /
  Last update: 2022-09-26 23:21    [W:0.068 / U:1.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site