Messages in this thread | | | Date | Mon, 26 Sep 2022 13:04:29 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net V2] net: lan743x: Fixes: 60942c397af6 ("Add support for PTP-IO Event Input External Timestamp (extts)") |
| |
On Fri, 23 Sep 2022 15:11:34 +0530 Raju Lakkaraju wrote: > Subject: [PATCH net V2] net: lan743x: Fixes: 60942c397af6 ("Add support for PTP-IO Event Input External Timestamp (extts)") > > Remove PTP_PF_EXTTS support for non-PCI11x1x devices since they do not > support the PTP-IO Input event triggered timestamping mechanisms > added > > Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
The fixes tag should go before your sign-off. So something like:
Subject: eth: lan743x: reject extts for non-pci11x1x devices
Remove PTP_PF_EXTTS support for non-PCI11x1x devices since they do not support the PTP-IO Input event triggered timestamping mechanisms added [...]
Fixes: 60942c397af6 ("Add support for PTP-IO Event Input External Timestamp (extts)") Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
I'd be good to add to the commit message what the user-visible problem will be. Crash or just silently accepting a config which won't work?
| |