lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH-next v1] arm64: dts: rockchip: Enable NVM Express PCIe controller on rock3a
Date
Hi,

On 26-09-22, 06:14, Anand Moon wrote:

> + pcie30_3v3: gpio-regulator {
> + compatible = "regulator-gpio";
> + regulator-name = "pcie30_3v3";
> + regulator-min-microvolt = <100000>;
> + regulator-max-microvolt = <3300000>;
> + gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>;
> + gpios-states = <0x1>;
> + states = <100000 0x0>, <3300000 0x1>;
> + };

This is actually no different from vcc3v3-pcie regulator?

> +&pcie30phy {
> + data-lanes = <0 1 2 3>;
> + phy-supply = <&vcc3v3_pi6c_03>;
> + status = "okay";
> +};

It seems that there is no need to define additional data-lanes when
the pcie3x1 node is not enabled, and phy-supply seems unnecessary on
this board.

Excuse me, can you try the patches I posted? Lspci can recognize
pcie3x2 normally, but I don't have a spare nvme hard drive right
now to test if it works.

Thanks, Chukun

---
Chukun Pan (3):
arm64: dts: rockchip: Add regulator suffix to ROCK3 Model A
arm64: dts: rockchip: Rename pinctrl label of pcie2x1 on rock-3a
arm64: dts: rockchip: Add PCIe v3 nodes to rock-3a

.../boot/dts/rockchip/rk3568-rock-3a.dts | 36 ++++++++++++++-----
1 file changed, 27 insertions(+), 9 deletions(-)

--
2.25.1

\
 
 \ /
  Last update: 2022-09-26 20:23    [W:0.107 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site