lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v3 6/6] freezer,sched: Rewrite core freezer logic
    On Mon, Sep 26, 2022 at 05:49:16PM +0200, Christian Borntraeger wrote:

    > Hmm,
    >
    > #define ___wait_is_interruptible(state) \
    > (!__builtin_constant_p(state) || \
    > state == TASK_INTERRUPTIBLE || state == TASK_KILLABLE) \
    >
    > That would not trigger when state is also TASK_FREEZABLE, no?

    Spot on!

    signal_pending_state() writes that as:

    state & (TASK_INTERRUPTIBLE | TASK_WAKEKILL)

    which is the correct form.

    diff --git a/include/linux/wait.h b/include/linux/wait.h
    index 14ad8a0e9fac..7f5a51aae0a7 100644
    --- a/include/linux/wait.h
    +++ b/include/linux/wait.h
    @@ -281,7 +281,7 @@ static inline void wake_up_pollfree(struct wait_queue_head *wq_head)

    #define ___wait_is_interruptible(state) \
    (!__builtin_constant_p(state) || \
    - state == TASK_INTERRUPTIBLE || state == TASK_KILLABLE) \
    + (state & (TASK_INTERRUPTIBLE | TASK_WAKEKILL)))

    extern void init_wait_entry(struct wait_queue_entry *wq_entry, int flags);

    Let me go git-grep some to see if there's more similar fail.

    \
     
     \ /
      Last update: 2022-09-26 20:18    [W:5.084 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site