Messages in this thread | | | Date | Mon, 26 Sep 2022 23:00:31 +0800 | From | Leo Yan <> | Subject | Re: [PATCH] perf arm-spe: augment the data source type with neoverse_spe list |
| |
On Mon, Sep 26, 2022 at 02:10:32PM +0000, Ali Saidi wrote: > > When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf > > arm-spe: Use SPE data source for neoverse cores") augment the type with > > source information by MIDR. However, is_midr_in_range only compares the > > first entry in neoverse_spe. > > > > Change is_midr_in_range to is_midr_in_range_list to traverse the > > neoverse_spe array so that all neoverse cores synthesize event with data > > source packet. > > > > Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores") > > Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com> > > Thanks for catching this, you're absolutely right. > > Reviewed-by: Ali Saidi <alisaidi@amazon.com>
It's also good for me: Reviewed-by: Leo Yan <leo.yan@linaro.org>
| |