Messages in this thread | | | Date | Mon, 26 Sep 2022 14:26:07 +0100 | From | Daniel Thompson <> | Subject | Re: [PATCH linux-next] backlight: use sysfs_emit() to instead of scnprintf() |
| |
On Fri, Sep 23, 2022 at 06:34:48AM +0000, cgel.zte@gmail.com wrote: > Subject: [PATCH linux-next] backlight: use sysfs_emit() to instead of > scnprintf() > From: ye xingchen <ye.xingchen@zte.com.cn> > > Replace the open-code with sysfs_emit() to simplify the code. > > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> > --- > drivers/video/backlight/lm3533_bl.c | 10 +++++-----
Looks like a good change but the topic tag ('backlight:') looks a bit generic for something that only impacts the lm3533_bl.c driver.
Also it would be good if this patchset included the same fix for *all* drivers that a grep shows contain this code pattern (e.g. git grep 'return scnprintf.*PAGE_SIZE').
Daniel.
| |