Messages in this thread | | | Date | Mon, 26 Sep 2022 12:43:18 +0100 | Subject | Re: [PATCH v2 6/8] scsi: libsas: use sas_phy_match_dev_addr() instead of open coded | From | John Garry <> |
| |
On 24/09/2022 08:34, Jason Yan wrote: > @@ -2115,8 +2109,7 @@ int sas_find_attached_phy(struct expander_device *ex_dev, > > for (phy_id = 0; phy_id < ex_dev->num_phys; phy_id++) { > phy = &ex_dev->ex_phy[phy_id]; > - if (SAS_ADDR(phy->attached_sas_addr) > - == SAS_ADDR(dev->sas_addr)) > + if (sas_phy_match_dev_addr(dev, phy))
It would be nice if the series was arranged such that sas_phy_match_dev_addr() is available when you introduce sas_phy_match_dev_addr()
> return phy_id; > }
Thanks, John
| |